-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use mimalloc as the default allocator #7059
Conversation
Compilation Memory Report
|
Execution Memory Report
|
Compilation Report
|
Execution Report
|
Some good compilation time improvements here for such a small change but the memory reports are broken |
Interesting, thought rust had quite a good allocator |
FWIW I tried the profiling I do with Instruments in #7053 and it seems to have bombed (I'm on Mac): Or I'm not sure what happens exactly, usually it runs for minutes, and the 12GB is also not something I have seen before. If I un e.g. But no, even that's not true, I have stack trace: It just shows way more memory than expected. |
Yeah, heaptrack reports that it doesn't work with custom allocators so we may need to replace this tooling for something else if we go forwards with this. |
@ludamad Rust just uses the default system allocator |
Looks like valgrind's massif tool isn't working either |
Profiling with |
This could be something to continue looking into for the future but I currently can't seem to profile memory usage of jemalloc, and any alternate allocator in general would break our CI so I'm closing this for now despite the possible performance gains. |
Description
Problem*
Resolves
Summary*
Testing to see if this improves performance
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.